-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Handle IPv6 hostname correctly (closes #806) #933
Conversation
Thank you @JohannaHartmann In terms of specs, I think ideally it would be to add generic specs for stubbing and request expectations |
Thank you @JohannaHartmann ! |
It's released as 3.12.1 |
Wrapped the hostname in brackets to separate it from the port, when it is an IPv6 address.
It is an attempt to fix the issue #806.
Is the
net_http_spec.rb
the right place for the added specs or should I rather put them into a new filenet_http_utility_spec.rb
?