Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Net::HTTP adapter so that it returns nil for an empty body response. #190

Merged
merged 1 commit into from
Jul 23, 2012
Merged

Fix Net::HTTP adapter so that it returns nil for an empty body response. #190

merged 1 commit into from
Jul 23, 2012

Commits on Jun 12, 2012

  1. Fix Net::HTTP adapter so that it returns nil for an empty body resp… 

    …onse.

This mirrors the real behavior of Net::HTTP and is the source of myronmarston/vcr#173.

A couple things to note:

- Rather than hitting an external URL (httpstat.us/204), this should probably
  hit the local webmock server; however, I can't figure out how to make the
  webmock server return a different response for different requests since it's
  writing directly to the socket w/o any request context available. Maybe it
  should be refactored to use rack or sinatra?
- I have no idea why, but Curb is returning a 400 Bad Request response for
  the request. Weird. Not sure why or how to fix it.
    @myronmarston
    myronmarston committed Jun 12, 2012
    Configuration menu
    Copy the full SHA
    f7b3230 View commit details
    Browse the repository at this point in the history