Adds rack as dev dependency and removes from lib #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you revisit? had a typo on rake vs rack |
| @@ -33,6 +33,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'excon', '>= 0.27.5' | |||
| s.add_development_dependency 'minitest', '~> 5.0.0' | |||
| s.add_development_dependency 'rdoc', ((RUBY_VERSION == '1.8.6') ? '<= 3.5.0' : '>3.5.0') | |||
| s.add_development_dependency 'rake' | |||
There was a problem hiding this comment.
This probably wants to be "rack":
s.add_development_dependency 'rack'
|
@bblimke I can't see any reason why webmock/utils was required, so I removed it. I added a changelog entry and dumped the version to 1.22.1 Want to release again? |
|
probably want to remove from |
|
ahh good catch |
davidbegin
force-pushed
the
move-rack-to-dev-only
branch
3 times, most recently
from
f008840
to
b264f26
Compare
|
I can not tell rake and rack apart today. @kbrock I think I got everything, see anything else? |
|
@davidbegin very nice - thanks for help |
|
@kbrock thanks for all your help! I needed a second set of eyes today. So once CI passes, I am going to merge this in. |
davidbegin
added a commit
that referenced
this pull request
Oct 13, 2015
Adds rack as dev dependency and removes from lib
|
thanks @davidbegin our build is back to green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.