Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json 'label' and 'name' collision in SpectrumAnalyzer? #18

Closed
matthewware opened this issue Jan 19, 2015 · 3 comments
Closed

json 'label' and 'name' collision in SpectrumAnalyzer? #18

matthewware opened this issue Jan 19, 2015 · 3 comments

Comments

@matthewware
Copy link
Collaborator

Creating a new SpectrumAnalyzer object creates a 'label' field in Instruments.json. It seems like the enaml code is looking for a 'name' field. startup.py fails if you replace 'label' with 'name' in the json. 'deviceName' field also fails on startup
@matthewware
Copy link
Collaborator Author

Changing line 22 of InstrumentManagerView.enaml to

    title := '{} ({})'.format(instr.label, instr.__class__.__name__)

seems to allow a work around. Haven't tested this extensively.

@matthewware
Copy link
Collaborator Author

Closed in 345eba8

@blakejohnson
Copy link
Collaborator

Your fix looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewware @blakejohnson