Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes for edge #34

Merged
merged 4 commits into from

2 participants

@jtgeibel

Bruno,

Here are 4 commits that fix various things I've run into recently. In particular dates shown on the forums were displayed as a time only (no date info) and the new RJS for submitting forum replies was giving me errors.

Some of the other changes improve compatibility with more recent versions of rails 2.3.

-Justin

@jtgeibel jtgeibel commented on the diff
app/models/message.rb
@@ -8,7 +8,7 @@ class Message < ActiveRecord::Base
has_many :children, :class_name => "Message", :foreign_key => "parent_id"
has_many :message_threads
- named_scope :parents, :conditions => "parent_id IS NULL"
+ # named_scope :conversation_roots, :conditions => "parent_id IS NULL"

Renamed as .parents conflicts with an existing active record method. Also commented out as this is not used anywhere yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jtgeibel jtgeibel commented on the diff
lang/ui/en.yml
@@ -2,7 +2,7 @@ en:
date:
formats:
published_date: "%m/%d/%Y"
- date_ago: "%b %Y"
+ date_ago: "%b %d, %Y"

In the commit that changes the display of time_ago, I only modified the english locale. Should I have updated the other locales as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bborn bborn merged commit ce8c381 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.