Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress astra local #1022

Merged
merged 52 commits into from
Apr 24, 2024
Merged

Cypress astra local #1022

merged 52 commits into from
Apr 24, 2024

Conversation

nirajCITZ
Copy link
Contributor

Added Astra call to APS API test scripts and updated docker compose file for keycloak image

ikethecoder and others added 30 commits September 30, 2022 13:07
* Feature/keycloak migration (#580)

* Feature/sprint 56 UI fixes (#596)

* Add fixes for deleting application optimistically and preventing saves in controls dialog

* Tighten up applications mocks, errors

* fix email search for finding user by email

* fix ns switch error

* remove switchto from perm ticket

* fixes for updating roles in clients (#594)


Co-authored-by: Joshua Jones <joshua@general-metrics.com>

* Feature/issue 237 access stale (#599)

* resolve build error

* fix error with upd roles

* fix display_name undefined ns access

* fix display_name undefined ns access

* upd logging details for online migration

* upd e2e keycloak with client mappers

* make title required for dataset (#606)

Co-authored-by: Joshua Jones <joshua@general-metrics.com>
Products page refresh (#595)
Test automation updates
fix consumer save error failed to construct formdata (#622)
Release Login Refresh Shared IdP Org Assignment
Feature/shared idp cypress (#673)
Feature/shared idp cypress (#680)
Feature/shared idp cypress (#687)
Feature/shared idp cypress (#690)
Cypress automation updates
Build feeder in test same way as portal
Release 1.2.6 changes
R1.2.6 bug fixes and ns access ui upgrade
fix feeder force sync on activity
Automation scripting updates
Email edit and ops metrics fix
increase max records for query resources (#781)
Release to test - feature public key
Fix for feature 518 public keys
Cypress automation updates
ckan out of sync issue
Cypress support for gwa-cli
Fix the test failed due to change in gwa generate-config output (#958)
aps-2198 fix npm access denied
ikethecoder and others added 5 commits March 6, 2024 16:00
Sort products by name alphabetically (#1007)
Added steps to enable code coverage
* add a nextapp-dev script

* improve the format of the dataset

* upd mock for dataset and upd css
ikethecoder
ikethecoder previously approved these changes Mar 28, 2024
@ikethecoder ikethecoder self-requested a review March 28, 2024 16:09
@ikethecoder ikethecoder dismissed their stale review March 28, 2024 16:09

still some changes needed

@rustyjux
Copy link
Contributor

rustyjux commented Apr 3, 2024

Q: if Astra picks up vulnerabilities of an unacceptable impact level (currently high or medium), how can we view the scan results with the vulnerability details?

It seems to me the results are only written to cypress/fixtures/state/scanResult.json and we need to add another upload step to .github/workflows/aps-cypress-e2e.yaml so we can access the results.

@rustyjux
Copy link
Contributor

@ikethecoder @Elson9 this is ready for review now.

I added a Python script to create a Jira issue with the relevant vulnerability details.

I also added exit 1 on the step which reviews the Cypress results to cause a failed GHA status. If there are any high/med issues from Astra, there will be a failed test in Cypress > GHA will fail. And thus I added if: failure() to only run the Astra results processing steps in that case.

Example of when Astra hits vulnerability (I modified the severity up from Low - these aren't real issues)
image

Example Jira issue (will delete later, just left it for review)

@rustyjux rustyjux merged commit 22446d4 into dev Apr 24, 2024
3 checks passed
@rustyjux rustyjux deleted the cypress_astra_local branch April 24, 2024 20:20
Elson9 added a commit that referenced this pull request Jun 6, 2024
* changes for local dev w/ npm

* Cypress astra local (#1022)

* Added Astra scans to e2e tests
---------

Co-authored-by: ike thecoder <ikethecoder@copeconsulting.ca>
Co-authored-by: Joshua Jones <joshua@general-metrics.com>
Co-authored-by: Elson9 <Elson9@users.noreply.github.com>
Co-authored-by: Russell Vinegar <38586679+rustyjux@users.noreply.github.com>
Co-authored-by: Russell Vinegar <russell.vinegar@gov.bc.ca>

* changes for local dev w/ npm

* Move ns dropdown

* save and load recently viewed gws

* search namespaces

* oops - remove local dev changes

* fix UserData.userId property reference

* fix ip

* maintain focus, style, fix type errors

* ns to gw in text

* include current gw in recently viewed

* add query to whitelist

* remove current gw from recently viewed

* edit display name - WIP, query and mutation inc

* touch up ns search

* style edit display name

* add uma2 test and service

* add displayName to mocks

* show ns displayname on namespaces page

* add new graphql for updating display name

* add the enforcement on the list extension

* integrate into frontend

* upd unit tests

* add graphql whitelist query

* fix for no namespace on name

* return displayName from currentNamespace query

---------

Co-authored-by: Russell Vinegar <russell.vinegar@gov.bc.ca>
Co-authored-by: nirajCITZ <94716060+nirajCITZ@users.noreply.github.com>
Co-authored-by: ike thecoder <ikethecoder@copeconsulting.ca>
Co-authored-by: Joshua Jones <joshua@general-metrics.com>
Co-authored-by: Russell Vinegar <38586679+rustyjux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants