Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"attribute_character_encoding" should be renamed to "attr_character_encoding" #54

Open
amanji opened this issue May 18, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@amanji
Copy link
Contributor

amanji commented May 18, 2023

As per the Character Encoding Overlay in the OCA Specification, the per attribute field is unfortunately abbreviated as "attr_character_encoding". This is not aligned with other fields that use the full "attribute" name but until the OCA Specification is updated we will have to align our OCA bundles.

@amanji amanji added the bug Something isn't working label May 18, 2023
@swcurran
Copy link
Contributor

Opened issue in OCA Parser. Waiting on feedback if the issue is the parser or the spec.

THCLab/oca-parser-xls#7

@amanji
Copy link
Contributor Author

amanji commented May 20, 2023

I believe it is the spec that needs to be aligned. An abbreviation is also being used for "attr_standars". For now I have included both the abbreviated and full form in the OCA bundle overlay classes with a deprecated flag on the abbreviated form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants