-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow unbounded search queries #762
Comments
Can you define what unbounded means in this context? Is there a valid use case for the UI to use these queries? |
Here is an example from the script:
Unbounded in this context means the search does not contain a query parameter that narrows the scope of the search. On the search engine side such a search can return >1 million hits, and then the API filters the results into a subset and limits the number of records returned to the user. These types of queries do not come from the UI, they are coming from outside sources querying the API directly. Though the UI does allow wild card queries that have similar results like this one:
|
Unbounded queries are end up querying/fetching millions of records, and overwhelming the search-engine.
Examples of some unbounded queries can be found in the orgbook-configurations
./manage
script; https://github.com/bcgov/orgbook-configurations/pull/137/files#diff-63baa3a336ec0b711e0cbe2e1015954578737523843dd17f6ddaed70d50f027fThe text was updated successfully, but these errors were encountered: