Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing styles to theme scss/css #5

Closed
8 tasks
CraigClark opened this issue May 3, 2023 · 0 comments · Fixed by #6
Closed
8 tasks

Add existing styles to theme scss/css #5

CraigClark opened this issue May 3, 2023 · 0 comments · Fixed by #6
Assignees
Labels
enhancement New feature or request

Comments

@CraigClark
Copy link
Collaborator

OP timer


This feature support the following requirements

Theme is required as part of the base-build

Additional context

There is an existing design system to get started with.

Proposed solution

  • Write using old @import method in scss because that's what BS5 uses
  • Make scss modular
  • Where possible use atomic design principals as requested by @chrislaick
  • do not change the selectors from what the design system uses
  • prefer scss variables over css variables, they offer more options in writing sass and this project will have a static theme, so no need to access variables via the dom

Dev workflow

  • I have written functional tests against the UAT test cases
  • I have run the functional tests and they pass
  • I have written integration tests on areas that may be affected by this feature
  • I have written integration tests under conditions which the feature should not work
  • I have run the Integration tests and they pass
  • I have added a comment to this issue with steps the reviewer needs to follow when doing QA
  • I have verified that the feature is ready for QA in the development environment.

Definition of done (DoD)

  • generated css matches 1 to 1 with existing style guide
@CraigClark CraigClark added the enhancement New feature or request label May 3, 2023
@CraigClark CraigClark self-assigned this May 3, 2023
@CraigClark CraigClark linked a pull request May 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant