-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a Compliance officer, I can see differences between versions of SWRS reports #268
Comments
Are they looking for different things? Like differences in emissions? What are the specific differences? If not, a file comparison would work. We'd need to show them an example of what a diff looks like between two XML files (if they aren't familiar with the XML format it might not be the best solution). |
User story to be validated |
Q from July 27 meeting: What differences do we need to see between versions of reports? |
MVP - could show ALL the differences, then they can scroll to look at the differences they actually need to see. |
Raj to mockup what a diff might look like (drawing on tools such as https://www.npmjs.com/package/react-diff-viewer) with emphasis on keeping it very simple in regards to the time we have available. |
@dleard can you help @rajpersram with downloading and formatting XML files (and perhaps re-encoding them from UTF-16 to UTF-8) to see what a diff looks like. Screenshots and/or a recording could be passed to the C&E team to show them what a diff would look like |
@rajpersram once the design is complete, can it be added to this card? |
Report ID entered into each field, which automatically shows the diff for each on the respective left and right side. Contents can be cleared by starting a new search. The 'Summarize Changes' toggle button would either show the full documents with highlighted changes, or show just the highlighted changes on their own. Only numerical report IDs will give results (error to show on input field otherwise: "Invalid entry. Input may only contain 5 digit number."). |
@rajpersram Now that the UX design work is done for this card, I'll move it back to the backlog |
@dleard @naomiaro @pbastia Hey team! Can you please add your planning poker estimates with ZenHub |
The ggircs_app user/schema needs the swrs_history / swrs_extract schemas included (with select only privileges). Work is done here: |
Awesome diff @dleard! Thank you for walking me through the feature and all the troubleshooting you had to do to make it work. |
Great job troubleshooting @dleard! Can't wait to get this in front of the Compliance Team. |
Description:
As a Compliance officer, I can quickly see differences between version of SWRS reports within two XML files displayed side by side.
Given a report ID, we can retrieve the original XML report via the foreign keys located in the
swrs_history.report
table.The XML string needs to be formatted (e.g. with https://www.npmjs.com/package/xml-formatter), its syntax highlighted (e.g. with https://prismjs.com/) prior to the diff being rendered (e.g. with https://github.com/praneshr/react-diff-viewer)
Miro board reference: CE Discovery Space
Acceptance Criteria:
In the GGIRCS app,
The text was updated successfully, but these errors were encountered: