Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - UI Displaying Person Giving Notice for some Legacy Registration Unit Notes #20615

Closed
2 tasks done
LizGovier opened this issue Apr 5, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels

Comments

@LizGovier
Copy link
Collaborator

LizGovier commented Apr 5, 2024

  • Remove the person giving notice information in Unit Notes for Residential and Non Residential Exemption.
    All other Unit notes should have a section for Person Giving Notice (CAU, CAUE, CAUC, 102, NPUB, NCON, TAXN)
  • Verify, remove person giving notice from the staff search result report.

Background:
As part of the data migration data quality analysis, note records were identified where the note name and address was identical to the submitting party name and address. The decision was made to retain such note name and address information.
An API change is required to remove person giving notice information if the document type is not in the above list.
Note document types to exclude: REG_103E,EXNR,NCAN,REG_103,NRED,STAT,REST,REGC,EXRS

In Dev
image.png

Design
image.png

@doug-lovett doug-lovett changed the title API - UI showing SP in Unit Notes after Legacy Corrections API - UI Displaying Person Giving Notice for some Legacy Registration Unit Notes Apr 5, 2024
@chdivyareddy
Copy link
Collaborator

Verified in DEV!

MHR 107983
image.png

@chdivyareddy
Copy link
Collaborator

Hey @doug-lovett , here are some examples in TEST where the Person Giving Notice is displayed for the legacy registrations residential exemption unit notes. Could you please take a look, thanks!

MHR: 107161, 107154, 106080
image.png

@doug-lovett
Copy link
Collaborator

doug-lovett commented Apr 10, 2024

@chdivyareddy the change I made was for the post data migration, no DB2 configuration where the issue was originally raised in 20535. I will expand the change to include pre data migration DB2 unit note information.

@doug-lovett
Copy link
Collaborator

@chdivyareddy the update to include legacy DB2 unit notes when conditionally displaying the person giving notice is now in TEST.

@chdivyareddy
Copy link
Collaborator

Thank you @doug-lovett for the quick fix:)

Verified in TEST!

MHR 106080
image.png

@PCC199 PCC199 closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants