Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Transfers - Adding a Person jumps to next section #20617

Closed
LizGovier opened this issue Apr 5, 2024 · 14 comments
Closed

UI - Transfers - Adding a Person jumps to next section #20617

LizGovier opened this issue Apr 5, 2024 · 14 comments
Assignees
Labels
Assets bug Something isn't working UX Assurance

Comments

@LizGovier
Copy link
Collaborator

LizGovier commented Apr 5, 2024

DEV and TEST environment for both QS and Staff

All Transfer Types
When adding/Editing a person or business and click 'Done', the screen jumps to the next section below when it should remain on the ownership component.

Solution: Add a 'Scroll to' effect when clicking 'Done'. Should scroll to the top of the Owners Table.

Clip
Private Zenhub Video

@LizGovier LizGovier added Assets bug Something isn't working UX Assurance labels Apr 5, 2024
@dimak1 dimak1 self-assigned this Apr 9, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Apr 9, 2024

@LizGovier @arlentees I updated to scroll to the top of Home Owners table, but I don't think it is bug, more of enhancement.

@dimak1
Copy link
Collaborator

dimak1 commented Apr 9, 2024

@LizGovier
Copy link
Collaborator Author

LizGovier commented Apr 9, 2024

Hey @dimak1
We groomed this last week and decided it should be in the bug column as this might have been a Vue 3 upgrade issue.

I'm still getting the same result when I add a person.

Private Zenhub Video

@dimak1
Copy link
Collaborator

dimak1 commented Apr 9, 2024

@LizGovier bug it is.. but you are not using the preview link :)

@LizGovier
Copy link
Collaborator Author

Hey @dimak1 I'm on the Dev Environment using the link https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app/dashboard and still getting the same result where I get jumped down to the next section:

@dimak1
Copy link
Collaborator

dimak1 commented Apr 10, 2024

@LizGovier I fixed the scroll. Add, Remove, Cancel buttons, for Person and Business should scroll to top of table now. Preview link: https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app

@LizGovier
Copy link
Collaborator Author

LizGovier commented Apr 10, 2024

Thanks @dimak1 ! I can see it now. Is it possible to have it stoll to the top of the 'Add a person' button. It would be good for the users to see the Home Tenancy Type.

Screen Shot 2024-04-10 at 12.25.29 PM.png

@dimak1
Copy link
Collaborator

dimak1 commented Apr 10, 2024

@LizGovier yes, it's easy to update, will do!

Edit: it's done https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app/

@LizGovier
Copy link
Collaborator Author

Thank you @dimak1
This is great and RFQA!

@dimak1
Copy link
Collaborator

dimak1 commented Apr 11, 2024

Merged to Dev.

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Apr 12, 2024

Hey @dimak1 , looks like Chrome and Safari is working as expected, but with the Firefox browser, it doesn't auto scroll to the owners table, please take a look, thanks!

Current Behavior (Firefox):
image.png

@dimak1
Copy link
Collaborator

dimak1 commented Apr 12, 2024

@chdivyareddy thanks Divya, yes I can reproduce this in Firefox and looking into the fix.

@dimak1
Copy link
Collaborator

dimak1 commented Apr 12, 2024

Fixed scroll for Firefox and merged to DEV.

@chdivyareddy
Copy link
Collaborator

Verified in DEV!

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants