Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - MHR Owner Transfer Frontend Validation Error #22144

Closed
arlentees opened this issue Jul 4, 2024 · 8 comments
Closed

BUG - MHR Owner Transfer Frontend Validation Error #22144

arlentees opened this issue Jul 4, 2024 · 8 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@arlentees
Copy link
Collaborator

arlentees commented Jul 4, 2024

Reported in OPS ticket https://sbc-registries.atlassian.net/browse/ITOPS-120280

A client reported being unable to complete a transfer, and registries staff have confirmed the issue as well. When selecting a transfer due to sale or gift, a frontend validation alert appears underneath the pay component. However, no fields are highlighted in red.

@doug-lovett has taken a look at the data and suspects this is a UI issue. The following data was saved as a draft in PROD for registration number 050964:

{
  "mhrNumber": "050964",
  "declaredValue": 1,
  "consideration": "$1.00",
  "transferDate": "2024-06-01",
  "ownLand": false,
  "documentId": "63685590",
  "registrationType": "TRANS",
  "submittingParty": {},
  "clientReferenceId": "",
  "addOwnerGroups": [
    {
      "groupId": 1,
      "interest": "UNDIVIDED",
      "interestDenominator": 100,
      "interestNumerator": 99,
      "owners": [
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1Z 1B2",
            "region": "BC",
            "street": "229-1999 HIGHWAY 97 S"
          },
          "individualName": {
            "first": "GARRETT",
            "last": "VANDALE",
            "middle": "ROBERT"
          },
          "ownerId": 1,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633880",
          "suffix": "WILLIAM",
          "type": "COMMON",
          "groupId": 1,
          "action": "DELETED"
        }
      ],
      "status": "ACTIVE",
      "tenancySpecified": true,
      "type": "SOLE",
      "action": "DELETED"
    },
    {
      "groupId": 2,
      "interest": "UNDIVIDED",
      "interestDenominator": 100,
      "interestNumerator": 1,
      "owners": [
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1W 1M2",
            "region": "BC",
            "street": "733 MCCLURE ROAD"
          },
          "individualName": {
            "first": "DARCIE",
            "last": "CARTER"
          },
          "ownerId": 2,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633616",
          "type": "JOINT",
          "groupId": 2,
          "action": "DELETED"
        },
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1W 1M2",
            "region": "BC",
            "street": "733 MCCLURE ROAD"
          },
          "individualName": {
            "first": "KENDALL",
            "last": "CARTER"
          },
          "ownerId": 3,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633616",
          "type": "JOINT",
          "groupId": 2,
          "action": "DELETED"
        }
      ],
      "status": "ACTIVE",
      "tenancySpecified": true,
      "type": "SOLE",
      "action": "DELETED"
    },
    {
      "groupId": 3,
      "owners": [
        {
          "ownerId": 4,
          "phoneNumber": "2508633880",
          "phoneExtension": "",
          "suffix": "",
          "description": "",
          "address": {
            "country": "CA",
            "street": "229-1999 Highway 97 S",
            "streetAdditional": "",
            "city": "Kelowna",
            "region": "BC",
            "postalCode": "V1Z 1B2",
            "deliveryInstructions": ""
          },
          "action": "ADDED",
          "partyType": "OWNER_IND",
          "individualName": {
            "first": "GARRETT",
            "middle": "ROBERT WILLIAM",
            "last": "VANDALE"
          },
          "groupId": 3
        }
      ],
      "action": "ADDED",
      "type": "SOLE",
      "interestDenominator": 0,
      "interestNumerator": 0
    }
  ],
  "deleteOwnerGroups": [
    {
      "groupId": 7,
      "interest": "UNDIVIDED",
      "interestDenominator": 100,
      "interestNumerator": 99,
      "owners": [
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1Z 1B2",
            "region": "BC",
            "street": "229-1999 HIGHWAY 97 S"
          },
          "individualName": {
            "first": "GARRETT",
            "last": "VANDALE",
            "middle": "ROBERT"
          },
          "ownerId": 1,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633880",
          "suffix": "WILLIAM",
          "type": "COMMON"
        }
      ],
      "status": "ACTIVE",
      "tenancySpecified": true,
      "type": "COMMON"
    },
    {
      "groupId": 8,
      "interest": "UNDIVIDED",
      "interestDenominator": 100,
      "interestNumerator": 1,
      "owners": [
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1W 1M2",
            "region": "BC",
            "street": "733 MCCLURE ROAD"
          },
          "individualName": {
            "first": "DARCIE",
            "last": "CARTER"
          },
          "ownerId": 2,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633616",
          "type": "JOINT"
        },
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1W 1M2",
            "region": "BC",
            "street": "733 MCCLURE ROAD"
          },
          "individualName": {
            "first": "KENDALL",
            "last": "CARTER"
          },
          "ownerId": 3,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633616",
          "type": "JOINT"
        }
      ],
      "status": "ACTIVE",
      "tenancySpecified": true,
      "type": "JOINT"
    }
  ]
}

Note that most other transfers that were filed today completed successfully

@arlentees arlentees added Assets bug Something isn't working labels Jul 4, 2024
@arlentees
Copy link
Collaborator Author

@doug-lovett in the OPS ticket you mentioned that the data looked incorrect - what properties look off here?

@doug-lovett
Copy link
Collaborator

@arlentees the addOwnerGroups look invalid.

@dimak1 dimak1 self-assigned this Jul 4, 2024
@doug-lovett
Copy link
Collaborator

@dimak1 here is the current home info:

{
  "attentionReference": "",
  "clientReferenceId": "",
  "createDateTime": "1995-11-14T00:00:01-08:00",
  "declaredDateTime": "2019-07-19T10:28:18-07:00",
  "declaredValue": 121000,
  "description": {
    "baseInformation": {
      "circa": false,
      "make": "103",
      "model": "",
      "year": "1981"
    },
    "csaNumber": "",
    "csaStandard": "",
    "engineerName": "",
    "manufacturer": "CANAMERA",
    "otherRemarks": "",
    "rebuiltRemarks": "",
    "sectionCount": 2,
    "sections": [
      {
        "lengthFeet": 52,
        "lengthInches": 0,
        "serialNumber": "2050",
        "widthFeet": 24,
        "widthInches": 0
      }
    ]
  },
  "documentDescription": "RECORD CONVERSION",
  "documentId": "REG50964",
  "documentRegistrationNumber": "00050964",
  "hasCaution": false,
  "location": {
    "additionalDescription": "",
    "address": {
      "city": "KELOWNA",
      "country": "CA",
      "postalCode": "",
      "region": "BC",
      "street": "1999 HIGHWAY 97 SOUTH"
    },
    "block": "",
    "dealerName": "",
    "districtLot": "",
    "exceptionPlan": "",
    "landDistrict": "",
    "leaveProvince": false,
    "locationType": "MH_PARK",
    "lot": "",
    "meridian": "",
    "pad": "229",
    "parcel": "",
    "parkName": "WESTVIEW VILLAGE MOBILE HOME PARK",
    "partOf": "",
    "pidNumber": "",
    "plan": "",
    "range": "",
    "section": "",
    "status": "ACTIVE",
    "taxCertificate": false,
    "township": ""
  },
  "mhrNumber": "050964",
  "notes": [],
  "ownLand": false,
  "ownerGroups": [
    {
      "groupId": 7,
      "interest": "UNDIVIDED",
      "interestDenominator": 100,
      "interestNumerator": 99,
      "owners": [
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1Z 1B2",
            "region": "BC",
            "street": "229-1999 HIGHWAY 97 S"
          },
          "individualName": {
            "first": "GARRETT",
            "last": "VANDALE",
            "middle": "ROBERT"
          },
          "ownerId": 1,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633880",
          "suffix": "WILLIAM",
          "type": "COMMON"
        }
      ],
      "status": "ACTIVE",
      "tenancySpecified": true,
      "type": "COMMON"
    },
    {
      "groupId": 8,
      "interest": "UNDIVIDED",
      "interestDenominator": 100,
      "interestNumerator": 1,
      "owners": [
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1W 1M2",
            "region": "BC",
            "street": "733 MCCLURE ROAD"
          },
          "individualName": {
            "first": "DARCIE",
            "last": "CARTER"
          },
          "ownerId": 2,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633616",
          "type": "JOINT"
        },
        {
          "address": {
            "city": "KELOWNA",
            "country": "CA",
            "postalCode": "V1W 1M2",
            "region": "BC",
            "street": "733 MCCLURE ROAD"
          },
          "individualName": {
            "first": "KENDALL",
            "last": "CARTER"
          },
          "ownerId": 3,
          "partyType": "OWNER_IND",
          "phoneNumber": "2508633616",
          "type": "JOINT"
        }
      ],
      "status": "ACTIVE",
      "tenancySpecified": true,
      "type": "JOINT"
    }
  ],
  "status": "ACTIVE"
}

@dimak1
Copy link
Collaborator

dimak1 commented Jul 4, 2024

When was this bug actually reported? Do we know the Assets UI app version (from the bottom right corner) when the issue occurred?
This is good to know because we just deployed Assets Ul v3.2.31 and it contains bug fix for Transfer Validations. I cannot reproduce the issue in TEST, so maybe it is already fixed. @arlentees

I could try to go back few versions in my local dev env, to verify if issue exists in earlier versions.

@arlentees
Copy link
Collaborator Author

@dimak1 This was first reported yesterday - PROD is 3.2.27

@dimak1
Copy link
Collaborator

dimak1 commented Jul 4, 2024

Thanks, @arlentees, I tried 3.2.29 and 3.2.31 in my local dev env. The latest version 3.2.31 does not have the bug.

Screenshot 2024-07-04 at 13.38.40.png

Screenshot 2024-07-04 at 13.40.43.png

@dimak1
Copy link
Collaborator

dimak1 commented Jul 4, 2024

Ready for verification in UI v3.2.31.

@dimak1 dimak1 assigned chdivyareddy and unassigned dimak1 Jul 4, 2024
@chdivyareddy
Copy link
Collaborator

Verified in TEST using MHR 108196.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants