Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX : Name Examination UI. Fix Priority Queue toggle - make sure when its off, Standard NRs get picked up #22308

Closed
ozamani9gh opened this issue Jul 17, 2024 · 5 comments
Assignees
Labels
Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority1

Comments

@ozamani9gh
Copy link
Collaborator

Priority Queue is broken in MAIN Branch.

image.png

@ozamani9gh ozamani9gh added the Names Team Name Request Name Examination Team label Jul 17, 2024
@ozamani9gh ozamani9gh assigned EPortman and rarmitag and unassigned EPortman Jul 17, 2024
@ozamani9gh ozamani9gh added Priority1 NameX NameX and related services proxied via namex labels Jul 17, 2024
@EPortman
Copy link
Collaborator

EPortman commented Jul 22, 2024

URL: https://test.namex.bcregistry.gov.bc.ca/
To test this:

  1. Note the value of the priority queue toggle.
  2. Press the Examine Names button (get the next NR).
  3. The name it picks up should be the type noted in step 1
  4. Examine the name so that the next name can be examined.
  5. Flip the toggle.
  6. When pressing the get next button, it should match the value in the priority queue.
  7. Basically anytime Examine Names is clicked or get next is clicked it should fetch a name with a priority label that matches that of the toggle.

Original ticket of persisting data is also kept
Refreshing the page or going between the page, value is remembered for:

  • Status
  • Consent Required
  • Priority (can be different than priority queue toggle, this priority filters search, toggle filters when getting next NR)
  • Notified
  • Submitted
  • Last Update

@EPortman
Copy link
Collaborator

PR: bcgov/name-examination#1485

@EPortman
Copy link
Collaborator

Also, the Examine Names button will always examine the NR in progress if you have one. So when testing the Priority Queue's ability to get the next NR of priority or not, make sure you do not have a NR in progress.

@EPortman
Copy link
Collaborator

To tell if the NR is a priority NR:
image.png

@Mihai-QuickSilverDev
Copy link
Collaborator

Completed successful testing in NameX Test, and included Omid too. I am happy with the results. Moving to Ready for Release for Tuesday morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority1
Projects
None yet
Development

No branches or pull requests

4 participants