Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - Non Reg Staff Amend Permit Validation Error #22313

Closed
doug-lovett opened this issue Jul 17, 2024 · 6 comments
Closed

API - Non Reg Staff Amend Permit Validation Error #22313

doug-lovett opened this issue Jul 17, 2024 · 6 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@doug-lovett
Copy link
Collaborator

doug-lovett commented Jul 17, 2024

From Ops ticket https://sbc-registries.atlassian.net/browse/ITOPS-122062
When SBC staff created a transport permit the location civic address included a postal code.
When they submitted a permit amendment the location civic address did not contain the postal code. The API data validation returned the error:
Amend transport permit can only change the home location address street. City and province may not be modified.

Developer Note:
Ignore postal code when comparing location civic address for changes.

@doug-lovett doug-lovett added Assets bug Something isn't working labels Jul 17, 2024
@cameron-eyds cameron-eyds self-assigned this Jul 18, 2024
@cameron-eyds
Copy link
Collaborator

@doug-lovett Morning sir!
I'm having some troubles reproducing this in TEST, SBC Staff can only change the street address in the amendment and it just carries forward the other civic address properties. Was there a payload captured for the initial Transport Permit and/or the Amendment, might be useful in finding out how this record lost it's postal code between the two filings.

Or even better, if there was an extract of their MHR in test :D

@doug-lovett
Copy link
Collaborator Author

@cameron-eyds morning. I think this occurs in the legacy database configuration, so not DEV. I am making an API change as well to remove the postal code comparison as part of this permit amendment location check.

@cameron-eyds
Copy link
Collaborator

@doug-lovett Ah ok copy that, let me know if there is anything i can assist with/update UI side to support this.
I'll just assign you as well, want me to keep it in progress or move it back for now?

@doug-lovett doug-lovett changed the title Non Reg Staff Amend Permit Validation Error API - Non Reg Staff Amend Permit Validation Error Jul 18, 2024
@doug-lovett
Copy link
Collaborator Author

@cameron-eyds I think for this case updating the API is sufficient so long as the UI is not displaying the location address postal code.

@doug-lovett
Copy link
Collaborator Author

@chdivyareddy deployed to TEST.

@chdivyareddy
Copy link
Collaborator

Verified in TEST!

MHR 108164 using SBC account.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants