Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal API - update dissolution warnings targetDissolutionDate #22432

Closed
2 tasks
argush3 opened this issue Jul 24, 2024 · 1 comment
Closed
2 tasks

Legal API - update dissolution warnings targetDissolutionDate #22432

argush3 opened this issue Jul 24, 2024 · 1 comment
Assignees
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team

Comments

@argush3
Copy link
Collaborator

argush3 commented Jul 24, 2024

Currently, the legal api returns targetDissolutionDate in the warnings block for a business in dissolution as per the http response bellow.

The data block is just taken directly from the corresponding batch_processing.meta_data field which is populated by the dissolutions job when the business is first put into dissolution.

The logic for this needs to follow the logic in the updated designs

Update warnings code in the legal api to not directly populate the data block in INVOLUNTARY_DISSOLUTION warning with data from batch_processing.meta_data as is. We can still return targetDissolutionDate but it will be returned based on the rules in the updated designs .

{
  "business": {
    "legalName": "AC BEN 2022.DEC.5 19.16 TEST LIMITED",
    "legalType": "BEN",
    "state": "ACTIVE",
    "warnings": [
      ...
      {
        "code": "DISSOLUTION_IN_PROGRESS",
        "data": {
          "overdueARs": true,
          "overdueTransition": false,
          "targetDissolutionDate": "2025-09-01"
        },
        "message": "Business is in the process of involuntary dissolution.",
        "warningType": "INVOLUNTARY_DISSOLUTION"
      }
    ]
  }
}

TODOs

  • Update warnings code in the legal api to return targetDissolutionDate as per business rules provided in updated designs
  • Add/update tests. Ensure the scenarios provided in the designs are tested.
@argush3 argush3 added the Entities - David A label to filter on the tickets for the Entities based team that David is PO for. label Jul 24, 2024
@argush3 argush3 added the ENTITY Business Team label Jul 24, 2024
@chenhongjing chenhongjing self-assigned this Jul 29, 2024
@vishnup0422
Copy link
Collaborator

vishnup0422 commented Aug 1, 2024

The business in D1
BC0814589
Target dissolution date is extended by 30 days based on the new design.

Screenshot 2024-08-01 at 10.28.20 AM.png

The business in D2:

BC0816990

Screenshot 2024-08-01 at 10.32.17 AM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

4 participants