Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FYI] Retrieve PDF doc endpoint for gazette furnishing entry returning a stage 1 letter pdf #22530

Closed
vishnup0422 opened this issue Jul 26, 2024 · 2 comments
Labels
bug Something isn't working Entities - David A label to filter on the tickets for the Entities based team that David is PO for.

Comments

@vishnup0422
Copy link
Collaborator

The endpoint returning PDF doc for a business which has GAZETTE entry.

https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0693666/furnishings/40/document

Steps to Reproduce
Steps to reproduce the behavior:

  1. Move the business to stage 1 of dissolution.
  2. Modify the DB and run the dissolution job to move the business to Gazette entry in furnishings table.
  3. Fetch the PDF doc through the endpoint providing BusinessId and FurnishingsId.

Actual:
Able to retrieve Stage 1 PDF doc.

Expected behavior
Should return 404 for a business with Gazette entry furnishing Id.

This business has 2 entries.

Screenshot 2024-07-26 at 2.04.59 PM.png

Try retrieving the PDF doc through endpoint using 2 furnishingId's

Scenario1: : This is expected
BusinessId: BC0693666
FurnishingId: 40
Type: MAIL

Screenshot 2024-07-26 at 2.04.15 PM.png

Scenario2: this should return 404
BusinessId: BC0693666
FurnishingId: 45
Type: GAZETTE

Screenshot 2024-07-26 at 2.03.51 PM.png

@vishnup0422 vishnup0422 added bug Something isn't working Entities - David A label to filter on the tickets for the Entities based team that David is PO for. labels Jul 26, 2024
@vikas-gov vikas-gov changed the title Retrieve PDF doc endpoint for gazette furnishing entry returning a stage 1 letter pdf [FYI] Retrieve PDF doc endpoint for gazette furnishing entry returning a stage 1 letter pdf Aug 1, 2024
@chenhongjing
Copy link
Collaborator

@vikas-gov @davemck513 This is fixed with #22502. @vishnup0422 Can you help to verify it?

@vishnup0422
Copy link
Collaborator Author

vishnup0422 commented Sep 5, 2024

Picked a business with EMAIL and GAZETTE Entries

image.png

Fetch PDF with EMAIL furnishing ID

image.png

Fetch PDF with GAZETTE entryID 345

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - David A label to filter on the tickets for the Entities based team that David is PO for.
Projects
None yet
Development

No branches or pull requests

3 participants