SOLR NAMES/CONFLICTS VIEW - handle future effective filings

[JohnamLane]

Some filings in CPRD can have future effective dates. Since these filings can be withdrawn (cancelled) after filing, but before their effective date, the Solr cores should not be updated until the filing's effective date.
This example came from PROD:
BC1191987, filed an amalgamation on December 28th, 2018 (effective Jan 1, '19)
On December 28th, one of the predecessors (C1100250) had already been removed from the Solr index, but should have been active until the 1st of Jan.

[perkinss]

What if the filing is not withdrawn and someone else searches on the name and doesn't find it?

[JohnamLane]

@perkinss
The Solr cores should not be adjusted until the filing's effective date, that way we know that the filing is going ahead. Today we adjust the core on the filing date (prior to the effective date), so that causes problems when they withdraw the filing prior to the effective date.

[WalterMoar]

Here's another scenario, from production: corporation A0108383 calls in to staff and requests an Administrative Dissolution. Staff performs this at 13:28, but it's not effective until midnight. The event causes the trigger to fire at around 13:28, but the corporation is still active so Solr is updated. At midnight the corporation become historical, but there is no new event for this, so it is never deleted from the Solr core.

[thorwolpert]

Closing as we're moving to a new update style for SOLR