PTI-68: Initial Cleanup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTI-80: Authentication (WIP) PTI-81: List Page (WIP)
|
Just throwing everyone on these reviews, and whoever has the time to review them can do so. Obviously for this one its probably not reviewable, but in future. |
danieltruong
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably too gigantic to review, as its the initial commit of the entire code base, but here is a rough list of changes made:
Removed unused code, including code that may eventually be used, but would currently be broken.
Removed unused package.json dependencies.
Bumped all pacakge.json versions.
Ensured existing admin unit tests pass.
Most api unit tests also pass, but more work is still needed because the api is fairly gutted at the moment.
Updated old references to ACRFD to NRPTI instead, etc.
All Linters pass.
All code that was specifically edited/modified should have JSDoc (very work in progress code, and old code, may not).
Work on PTI-80 and PTI-81 is also in here, but it is still WIP.