make poll interval configurable #90
Conversation
Signed-off-by: Vitalij Reicherdt <vitalij.reicherdt@commerzbank.com>
vitalrev
force-pushed
the
feature/poll-interval-configurable
branch
from
5d4255f
to
35f6627
Compare
| @@ -46,6 +46,7 @@ public class IdentityConstants | |||
|
|
|||
| public const string ChallengeIdQueryParameterName = "pid"; | |||
| public const string ChallengePollUri = "vc/connect/poll"; | |||
| public const int PollInterval = 2000; | |||
There was a problem hiding this comment.
Any way we could make this configurable by reading an environment variable and fall back to the default value if that is not set?
I like the idea, however this requires the app to be rebuilt in order for the change to take effect.
There was a problem hiding this comment.
i've changed so that poll interval can be configured in appsettings.json and env var in manage script
|
@esune -- given what we found with argparse in Python land, maybe there is the equivalent we could use here? |
Yes, it should be just a matter of binding the value to an environment variable or configuration rather than hard-coding it. |
Signed-off-by: Vitalij Reicherdt <vitalij.reicherdt@icloud.com>
Signed-off-by: Vitalij Reicherdt <vitalij.reicherdt@icloud.com>
Signed-off-by: Vitalij Reicherdt <vitalij.reicherdt@icloud.com>
|
Thank you @vitalrev ! |
No description provided.