Fix broken authentication flow #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
esune
force-pushed
the
feature/dotnet3-upgrade
branch
from
76d53ca
to
d888c54
Compare
esune
commented
Oct 8, 2020
| @@ -178,7 +178,7 @@ configureEnvironment() { | |||
| # controller | |||
| export IDENTITY_SERVER_URL="${IDENTITY_SERVER_URL:-http://localhost:5000}" | |||
| export IDENTITY_SERVER_API_KEY="controller-api-key" | |||
| export IDENTITY_SERVER_WEB_HOOK_URL=${IDENTITY_SERVER_URL} | |||
| export IDENTITY_SERVER_WEB_HOOK_URL=${IDENTITY_SERVER_WEB_HOOK_URL:-http://$DOCKERHOST:5000} | |||
There was a problem hiding this comment.
This is the url used buy the agent to deliver webhooks, so it has to be on the internal docker network.
WadeBarnes
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused dependencies and services registered at startup.
Fixed broken authentication flow: the base url was being set incorrectly, resulting in a non-resolvable address in the QR code.
Tested in demo mode and it REALLY works this time 😅