Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new stations in Kamloops FC #1849

Closed
8 tasks
andrea-williams opened this issue Apr 4, 2022 · 4 comments
Closed
8 tasks

Add 2 new stations in Kamloops FC #1849

andrea-williams opened this issue Apr 4, 2022 · 4 comments
Assignees

Comments

@andrea-williams
Copy link
Collaborator

andrea-williams commented Apr 4, 2022

As a PE the forecaster I want West Kelowna and Station Bay 2 stations added to Kamloops FC in HFI Calc So That I can include those stations' weather data in my calculations for prep.

Additional Context

  • Andrea wrote a new Alembic migration script to add West Kelowna station in Penticton. Station appears locally and in dev envs in the database, but isn't showing up on the front end. Investigation revealed that fetch_paged_response_generator() in wfwx_api.py isn't including West Kelowna (1227) in iterator response. I've tried removing caching with use_cache=False and setting cache_expiry_seconds=0, and neither have worked. More troubleshooting required for this.
  • after getting to this point, I decided it was going to be too much work to take this on on the fly - it deserves a ticket in the backlog. DH has also indicated that we should be limiting the number of times we make changes to the selected prep stations for HFI Calc, due to time constraints.
  • see https://github.com/bcgov/wps/tree/task/add_west_kelowna for in-progress branch
  • Remember to add mappings for fire starts

Acceptance Criteria

  • Given I've navigated to Kamloops Fire Centre in HFI Calc, When I look at the Penticton planning area, Then I can see the West Kelowna - 1277 station second in the planning area list, with fuel type C7
  • Given I've navigated to Kamloops Fire Centre in HFI Calc, When I look at the Vernon planning area, Then I can see the "Station Bay 2 - 1359" station third in the planning area list, with fuel type C5

Definition of Done

  • Ready to Demo in Sprint Review
  • Does what I have made have appropriate test coverage?
  • Documentation and/or scientific documentation exists and can be found
  • Peer Reviewed by 2 people on the team
  • Manual testing of all PRs in Dev and Prod
  • Merged
@andrea-williams andrea-williams added 4Refinement this ticket is ready for refinement with the team User Requested User Story User story labels Apr 4, 2022
@Sybrand
Copy link
Contributor

Sybrand commented Apr 13, 2022

Hey team! Please add your planning poker estimate with ZenHub @conbrad @andrea-williams

@Sybrand Sybrand removed the 4Refinement this ticket is ready for refinement with the team label Apr 13, 2022
@conbrad conbrad self-assigned this Apr 14, 2022
@conbrad
Copy link
Collaborator

conbrad commented Apr 14, 2022

What are the net new station codes? Is it just 1227?

@conbrad
Copy link
Collaborator

conbrad commented Apr 19, 2022

1277 does not exist in WFWX API, 1359 does.

@conbrad
Copy link
Collaborator

conbrad commented Apr 19, 2022

Ok now 1277 is there...

@conbrad conbrad closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants