Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for DB to be ready in GA #373

Closed
2 tasks
Sybrand opened this issue Jun 25, 2020 · 2 comments
Closed
2 tasks

Wait for DB to be ready in GA #373

Sybrand opened this issue Jun 25, 2020 · 2 comments
Labels
Task Technical task that cannot be written as a user story

Comments

@Sybrand
Copy link
Contributor

Sybrand commented Jun 25, 2020

Describe the task
During github action job execution, wait for DB to be successfully spun up and ready before finishing.

Acceptance Criteria

  • Fail deployment if DB doesn't come up.
  • Wait for DB to become available.

Additional context

  • Currently the template is applied without waiting
  • We should probably only do this if it's a problem for us.
@Sybrand Sybrand added the Task Technical task that cannot be written as a user story label Jun 25, 2020
@Sybrand
Copy link
Contributor Author

Sybrand commented Mar 25, 2021

I think we can close this one. The DB deployment is significantly faster than the build process, so we are extremely unlikely to have to wait for the DB to be ready.

@andrea-williams
Copy link
Collaborator

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Technical task that cannot be written as a user story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sybrand @andrea-williams @jakemorr