Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export private interfaces #20

Closed
JeremyFunk opened this issue Apr 7, 2022 · 1 comment
Closed

Export private interfaces #20

JeremyFunk opened this issue Apr 7, 2022 · 1 comment

Comments

@JeremyFunk
Copy link

When trying to separate code into multiple functions using typescript it is sometimes not possible to define the type of arguments because Galeforce does not export all interfaces. An example:

const match = getMatch(matchId) // MatchDTO from galeforce
for (const p of match.data.info.participants){
    const runeData = getRuneData(p)
    ...
}
...

// Here I can't define the type because the Participant type is not exported.
const getRuneData = (participant: ?): string[] => {
    ...
}

Simply exporting all interfaces would solve this issue.
If you don't want to do this (let's be honest it's a really boring task) but think it is a good idea I can create a PR with the changes.

@JeremyFunk
Copy link
Author

See #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant