-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system/core/Output.php minify using wrong variable for $textareas_clean #2163
Comments
Good catch; it does look like this could use some attention. We're doing some other changes to the Output library, so I'll keep this in mind as something to spruce up as I go with other changes. |
narfbg
added a commit
that referenced
this issue
Jan 21, 2013
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this issue
Jun 29, 2013
narfbg
added a commit
that referenced
this issue
Dec 15, 2014
This feature has proven to be problematic and it's not nearly as flexible as a dedicated minifier library like Minify (http://www.minifier.org/, https://github.com/matthiasmullie/minify). The same results in terms of saving traffic can also be achievied via gzip compression (which should also be done on the httpd level, but we also support anyway) and stuff like mod_pagespeed. Reverts PR #965 Related issues as a track record proving how problematic this has been: #2078 #1499 #2163 #2092 #2387 #2637 #2710 #2120 #2171 #2631 #2326 #2795 #2791 #2772 Additionally, the count of contributors suggesting that the only way to fix the minifier problems is to remove it, is around the same as the count of people suggesting the feature to be implemented in the first place. It was experimental anyway ... the experiment failed.
ghost
pushed a commit
to goreilly/CodeIgniter
that referenced
this issue
Jan 3, 2015
This feature has proven to be problematic and it's not nearly as flexible as a dedicated minifier library like Minify (http://www.minifier.org/, https://github.com/matthiasmullie/minify). The same results in terms of saving traffic can also be achievied via gzip compression (which should also be done on the httpd level, but we also support anyway) and stuff like mod_pagespeed. Reverts PR bcit-ci#965 Related issues as a track record proving how problematic this has been: bcit-ci#2078 bcit-ci#1499 bcit-ci#2163 bcit-ci#2092 bcit-ci#2387 bcit-ci#2637 bcit-ci#2710 bcit-ci#2120 bcit-ci#2171 bcit-ci#2631 bcit-ci#2326 bcit-ci#2795 bcit-ci#2791 bcit-ci#2772 Additionally, the count of contributors suggesting that the only way to fix the minifier problems is to remove it, is around the same as the count of people suggesting the feature to be implemented in the first place. It was experimental anyway ... the experiment failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The minify method uses the wrong variable to determine whether to format textareas. As of this post, these are lines 722 and 761. See also: http://ellislab.com/forums/viewthread/229484/
Ln 722: preg_match_all('{<textarea.+</textarea>}msU', $output, $textareas_clean);
Ln 761: if ( ! empty($codes_clean))
{
preg_match_all('{<textarea.+</textarea>}msU', $output, $textareas_messed);
$output = str_replace($textareas_messed[0], $textareas_clean[0], $output);
}
The text was updated successfully, but these errors were encountered: