Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where you can not change the path freely. #1108

Conversation

ytetsuro
Copy link
Contributor

It is the same intention as the following PR.

#1105

defined has been DOCUMENT_ROOT by FCPATH in Serve.php.

https://github.com/bcit-ci/CodeIgniter4/blob/develop/system/Commands/Server/Serve.php#L82

@kenjis
Copy link
Member

kenjis commented Jul 22, 2018

It worked fine.
I was able to see Welcome page.

@lonnieezell
Copy link
Member

That should work fine. Thanks!

@lonnieezell lonnieezell merged commit 83ac2f4 into codeigniter4:develop Jul 23, 2018
@ytetsuro
Copy link
Contributor Author

Merged Thanks!

ytetsuro pushed a commit to ytetsuro/codeigniter-composer-installer that referenced this pull request Jul 23, 2018
ytetsuro pushed a commit to ytetsuro/codeigniter-composer-installer that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants