Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush out test coverage for Message 1 #22

Open
schwehr opened this issue Mar 24, 2019 · 0 comments
Open

Flush out test coverage for Message 1 #22

schwehr opened this issue Mar 24, 2019 · 0 comments

Comments

@schwehr
Copy link
Contributor

schwehr commented Mar 24, 2019

Looking at coverage for message1, the throw is the only line not covered. Need a message 1 that has a bad length. I know I've seen plenty in my logs, but need to either find one or make one up. And searching through many TB of logs isn't currently easy at the moment, crafting one would be easier. I'm currently having trouble with maven not doing a good job of showing me assert messages from junit, so it might take a bit.

if (six_state.bit_length() != 168)
    throw new AISMessageException("Message 1 wrong length"); // Untested line

And I realize that just hitting every line isn't enough, but it's a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant