Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to zero-based indexing, added locale compatibility. #13

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Changed to zero-based indexing, added locale compatibility. #13

merged 3 commits into from
Sep 4, 2019

Conversation

p2jones
Copy link
Contributor

@p2jones p2jones commented Aug 30, 2019

  • Changed to zero-based indexing
  • Added locale compatibility (issue 12)
  • Read in units
  • Check for OCV measurement before CV (OCV is currently ignored)

@bcliang
Copy link
Owner

bcliang commented Sep 4, 2019

TODO:

  • Add test for locale
  • Add test for units
  • Update version
  • Release to pypi

@bcliang bcliang merged commit 1022250 into bcliang:master Sep 4, 2019
@bcliang bcliang mentioned this pull request Sep 4, 2019
Closed
@bcliang bcliang mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p2jones @bcliang