Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load OCV Curve Data #15

Closed
bcliang opened this issue Sep 4, 2019 · 4 comments · Fixed by #17
Closed

Load OCV Curve Data #15

bcliang opened this issue Sep 4, 2019 · 4 comments · Fixed by #17

Comments

@bcliang
Copy link
Owner

bcliang commented Sep 4, 2019

Currently, OCVCURVE data is ignored by the parser (#13).

Instead, (if it exists) the OCV data should be kept and made accessible to the user.

Currently:

  • bool self.ocv_curve indicates if the DTA file contained an OCV curve in the header.

Fix:

  • persist OCVCURVE data. The curve table is expected to take the form:
OCVCURVE	TABLE	[__a_number__]
	Pt	T	Vf	Vm	Ach	Over
	#	s	V vs. Ref.	V	V	bits
  • provide a function to retrieve the time-series OCV data, if it exists
  • provide a function to indicate whether OCV data has been loaded
@bcliang
Copy link
Owner Author

bcliang commented Sep 4, 2019

The OCVCURVE table appears to be generated in framework 6.xx.

As of Gamry Framework 7.07, the OCVCURVE table is not generated. Instead, we can look to 2 lines indicating activity:

  1. DELAY TWOPARAM T [time, seconds] [rate, mV/s] Init. De&lay Time(s) Stab.(mV/s)
  2. EOC QUANT 0.2834373 Open Circuit (V)

DELAY indicates the desired stability threshold before the test may commence, and
EOC indicates the final OCV reading (in V)

Related to this, data from any CONDITIONING period is not saved by framework (run chronoamperometry for a specific amount of time before starting the experiment)
CONDIT TWOPARAM T [time, seconds] [operating potential, V] Conditionin&g Time(s) E(V)

@p2jones
Copy link
Contributor

p2jones commented Sep 5, 2019

Do you have documentation for different versions of DTA files? I've found this description but no details for different versions (6.xx or 7.xx).

@bcliang
Copy link
Owner Author

bcliang commented Sep 5, 2019

Unfortunately not. It just happens that some potentiostats that we use are on older licenses that cannot run with the newer framework version.

I put together most of the package based on real DTA files as well as Gamry's Framework Help Reference

@bcliang
Copy link
Owner Author

bcliang commented Sep 5, 2019

I have an initial implementation for this that returns either the contents of the ocvcurve table (or header param EOC), or None. Doesn't currently perform any number formatting, but will make sure it's locale-aware.

https://github.com/bcliang/gamry-parser/tree/ocvcurve-and-missing-tests

Once this feature is merged (along with tests), I'll rev the version of the package to 0.3.x

@bcliang bcliang mentioned this issue Sep 7, 2019
@bcliang bcliang closed this as completed Sep 21, 2019
@bcliang bcliang linked a pull request Feb 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants