Use /bin/bash as the exec shell on Unixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tapjs#14 by avoiding Dash on Ubuntu systems. As it happens, this module was working just fine, but the exec shell was exiting in a way that didn't match the exit of its last job.
All of these were here to work around the fact that exec() is /bin/dash on Linux, but /bin/bash on Darwin.
Sadly, in Node.js 0.10, one could not set the shell used by child_process.exec(), so all of the tests fail badly if the node is 0.10 and the shell is /bin/dash.
|
Once the travis-ci finishes, this should be good to go. 0.10 is failing on Travis because 0.10 does not allow one to set the shell used by cp.exec(), so it's removed in that last commit. Everything else was passing, so it should be good to go. |
|
awesome \o/ |
bcoe
added a commit
that referenced
this pull request
Dec 28, 2015
Use /bin/bash as the exec shell on Unixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14 by avoiding Dash on Ubuntu systems.
As it happens, this module was working just fine, but the exec shell was exiting in a way that didn't match the exit of its last job.