feat: align 'estimatesmartfee' rpc with bitcoind #1157
Conversation
|
Thanks, good call. I'll review it this week. |
Thanks @theanmolsharma . Also I noticed the coverage in RPCs are quite less so can make a test suite for them as well. |
|
Changed the test to be in the right file and ran a formatter on the file |
Please revert back the formatter changes. |
emjshrx
force-pushed
the
master
branch
2 times, most recently
from
1da7f24
to
d1335d3
Compare
|
Tested ACK |
|
since this is a breaking change, we must also include a release note in the CHANGELOG.md anyone who is using this API regularly for their application will get wrecked if they upgrade and don't comply. |
Thanks for bringing this to notice @pinheadmz . Have made the changes. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 69.55% 69.57% +0.01%
==========================================
Files 158 159 +1
Lines 26603 26607 +4
==========================================
+ Hits 18505 18511 +6
+ Misses 8098 8096 -2
☔ View full report in Codecov by Sentry. |
test/node-rpc-test.js
Outdated
| @@ -425,7 +425,7 @@ describe('RPC', function() { | |||
| const {genesis} = node.network; | |||
| let entry = await node.chain.getEntry(genesis.hash.reverse()); | |||
|
|
|||
| // Get current chain tip and chain height | |||
| // Get current chain tip and chain height | |||
There was a problem hiding this comment.
If you're going to touch this line, it should be like this:
// Get current chain tip and chain height
const chainHeight = node.chain.tip.height + 1;
const chainTip = util.revHex(node.chain.tip.hash);There was a problem hiding this comment.
Fixed this annoying formatting change. I did not intend to touch these lines.
|
merged 014a104 |
Changes the returned json attribute from 'estimatesmartfee' rpc to align with bitcoind docs . Also added a crude test to verify the same.
Fixes #1153