Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bech32m is not replaced with bench32m-browser when using browser #66

Closed
michalsmiarowski opened this issue Aug 11, 2022 · 3 comments · Fixed by #67
Closed

bech32m is not replaced with bench32m-browser when using browser #66

michalsmiarowski opened this issue Aug 11, 2022 · 3 comments · Fixed by #67

Comments

@michalsmiarowski
Copy link
Contributor

lib/encoding/bech32m.js file is not properly replaced with lib/encoding/bech32m-browser.js when using the lib in the browser. I think it's because it's not included in package.json browser field.

Here is the pull request that add support for bech32m - #61. As you can see two new files are created - bech32m.js and bech32m-browser.js. They should be mapped in the browser field in package.json:

browser: {
  ...
  "./lib/encoding/bech32m": "./lib/encoding/bech32m-browser.js",
  ...
}
@pinheadmz
Copy link
Member

want to open a PR for this?

@michalsmiarowski
Copy link
Contributor Author

Sure, I'll open a PR

@michalsmiarowski
Copy link
Contributor Author

michalsmiarowski commented Aug 11, 2022

@pinheadmz PR is ready - #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants