Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor seed=0 by checking if seed is none instead of using or operator #254

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

fyordan
Copy link
Collaborator

@fyordan fyordan commented Mar 20, 2023

This is probably why seed wasn't being honored, since 0 or random will be random everytime, its better to check explicitly for None.

@fyordan fyordan requested a review from bcollazo March 20, 2023 08:10
@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for catanatron-staging canceled.

Name Link
🔨 Latest commit 6d10b8e
🔍 Latest deploy log https://app.netlify.com/sites/catanatron-staging/deploys/641814fddea4d9000869db73

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4466013805

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 95.728%

Files with Coverage Reduction New Missed Lines %
catanatron_core/catanatron/state.py 2 97.17%
Totals Coverage Status
Change from base Build 4462284319: -0.1%
Covered Lines: 1367
Relevant Lines: 1428

💛 - Coveralls

Copy link
Owner

@bcollazo bcollazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@bcollazo bcollazo merged commit 0dc495c into master Mar 31, 2023
@bcollazo bcollazo deleted the fix-seed branch March 31, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants