Play Monopoly #29
Merged
Play Monopoly #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2020 19:32
dagarcia7
commented
Sep 28, 2020
| if not player_to_act.has_monopoly_card(): | ||
| raise ValueError("Player doesn't have monopoly card") | ||
| for player in self.players: | ||
| if not player_to_act.color == player.color: |
There was a problem hiding this comment.
thought this was easier than looping with indexes and checking against the current_player_index 🤷
dagarcia7
commented
Sep 28, 2020
| @@ -42,6 +42,9 @@ def has_knight_card(self): | |||
| def has_year_of_plenty_card(self): | |||
| return self.development_deck.count(DevelopmentCard.YEAR_OF_PLENTY) > 0 | |||
|
|
|||
| def has_monopoly_card(self): | |||
There was a problem hiding this comment.
I think eventually we can make a more generic (has_dev_card(card_type)) method to replace these
dagarcia7
commented
Sep 28, 2020
| game.execute(action_to_execute) | ||
|
|
||
|
|
||
| def test_play_monopoly_player_steals_cards(): |
There was a problem hiding this comment.
For this test, I wanted to show that player_to_act stole the ORE and left the other resources intact (in this case just WHEAT). I was too lazy to add some other resources in there, but can make this test stronger if necessary
bcollazo
approved these changes
Oct 4, 2020
| @@ -36,6 +37,11 @@ def test_year_of_plenty_possible_actions_not_enough_cards(): | |||
| assert len(year_of_plenty_possible_actions(player, bank_resource_deck)) == 1 | |||
|
|
|||
|
|
|||
| def test_monopoly_possible_actions(): | |||
| player = SimplePlayer(Color.RED) | |||
| assert len(monopoly_possible_actions(player)) == len(Resource) | |||
| assert player_to_steal_from_1.resource_deck.count(Resource.ORE) == 0 | ||
| assert player_to_steal_from_1.resource_deck.count(Resource.WHEAT) == 1 | ||
| assert player_to_steal_from_2.resource_deck.count(Resource.ORE) == 0 | ||
| assert player_to_steal_from_2.resource_deck.count(Resource.WHEAT) == 1 |
|
|
||
| players = [player_to_act, player_to_steal_from_1, player_to_steal_from_2] | ||
| game = Game(players) | ||
| action_to_execute = Action(player_to_act, ActionType.PLAY_MONOPOLY, Resource.ORE) |
| if not player_to_act.has_monopoly_card(): | ||
| raise ValueError("Player doesn't have monopoly card") | ||
| for player in self.players: | ||
| if not player_to_act.color == player.color: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.