Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob regression pattern. #54

Closed
bcomnes opened this issue Feb 1, 2022 · 1 comment
Closed

Glob regression pattern. #54

bcomnes opened this issue Feb 1, 2022 · 1 comment

Comments

@bcomnes
Copy link
Owner

bcomnes commented Feb 1, 2022

This (cpx './!(node_modules)**/*.{png,ico}' public") worked in 3.0.0, but doesn't work in 4.0.0 when run in a directory with a static/foo.png file. This glob doesn't end up copying anything (but should). Granted, using the ignore flag is more efficient and intuitive, however it should continue working as is.

@bcomnes
Copy link
Owner Author

bcomnes commented Feb 6, 2022

I found the culprit and proposed a solution: kaelzhang/node-glob-gitignore#8

If you are running into this issue on cpx2@^4 you can either run cpx2@^3 or convert your negative glob group into an git style ignore pattern while the issue is being resolved upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant