Fix PHP 8.1 compatibility #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On PHP 8.1 program would crash with the following message:
Fatal error: $GLOBALS can only be modified using the $GLOBALS[$name] = $value syntax
https://wiki.php.net/rfc/restrict_globals_usage
PHP 8.1 expects proper variance of child class methods, otherwise it will print the following notice: Return type of Base::offsetunset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void,..., https://php.watch/versions/8.1/internal-method-return-types
PHP 8.1 deprecated implicit conversions of float to int and passing null to non-nullable parameters: https://php.watch/versions/8.1/deprecate-implicit-conversion-incompatible-float-string https://php.watch/versions/8.1/internal-func-non-nullable-null-deprecation Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
|
I'll have a look at this soon. |
|
Any luck @ikkez? |
This was referenced Jan 23, 2022
|
almost done. |
|
should be good to go now. I've build a new dev bench for all unit tests and testings across multiple php version https://github.com/f3-factory/fatfree-dev I'll tag a new release soon. |
|
Been waiting a while on this one! Thank you all so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up #332 and added some more fixes