Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of hardcoded ESD key in global/shopware.con #9

Open
bcremer opened this issue Dec 18, 2014 · 1 comment
Open

Get rid of hardcoded ESD key in global/shopware.con #9

bcremer opened this issue Dec 18, 2014 · 1 comment

Comments

@bcremer
Copy link
Owner

bcremer commented Dec 18, 2014

After merging PR #8 I was thinking about creating a variable for the esd key to get rid of the hardcoded value in global/shopware.con.

# sites-available/example.com.conf
set $shopware_esd_key '552211cce724117c3178e3d22bec532ec';`
# global/shopware.con
location ^~ /files/$shopware_esd_key/ {
    internal;
}

Unfortunately that seems not possible with plain Nginx config.

@samuelvogel
Copy link
Contributor

Maybe it should be documented that this part actually is the ESD key from the Shopware config as a first step!

@bcremer bcremer mentioned this issue Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants