Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 TreeViewItem.from does not set parent on copied children #1042

Closed
klondikedragon opened this issue Mar 20, 2024 · 0 comments · Fixed by #1043
Closed

🐛 TreeViewItem.from does not set parent on copied children #1042

klondikedragon opened this issue Mar 20, 2024 · 0 comments · Fixed by #1043
Labels
bug Something isn't working

Comments

@klondikedragon
Copy link
Contributor

Describe the bug
The TreeViewItem.from factory constructor that makes a deep copy of itself and its children does not set the parent property of the children properly. This can break things in subtle ways on the tree data before the tree data is passed into the first widget build.

Additional context
I'll open a PR that fixes this.
@klondikedragon klondikedragon mentioned this issue Mar 20, 2024
Merged
3 tasks
@bdlukaa bdlukaa added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TreeViewItem.from should set parent properly klondikedragon/fluent_ui
2 participants
@bdlukaa @klondikedragon