Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unnecessary guard for no blocking labels #25

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: removed unnecessary guard for no blocking labels #25

merged 1 commit into from
Oct 19, 2023

Conversation

nickytonline
Copy link
Collaborator

I added a guard to check if the blocking labels were empty. It defaults to an empty string which jq can handle converting to an empty array, so the guard is unnecessary and actually breaks the action if no blocking labels are specified.

I've removed the guard and you can see it working as intended when no blocking labels are specified.

See these two test issues when there are no blocking labels:

@bdougie bdougie merged commit 1439165 into bdougie:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants