Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canonicalize paths in the index #59

Merged
merged 4 commits into from
Sep 29, 2023
Merged

fix: canonicalize paths in the index #59

merged 4 commits into from
Sep 29, 2023

Conversation

bdraco
Copy link
Owner

@bdraco bdraco commented Sep 29, 2023

Example case

alexpy became AlexPy and we can't see the new wheel so we need to canonicalize the path before figuring out which files to put on the html page

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (183e27c) 97.66% compared to head (8883cf0) 97.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   97.66%   97.64%   -0.03%     
==========================================
  Files           9        9              
  Lines         300      297       -3     
  Branches       39       39              
==========================================
- Hits          293      290       -3     
  Misses          6        6              
  Partials        1        1              
Files Coverage Δ
src/index_503/__init__.py 100.00% <100.00%> (ø)
src/index_503/index.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title fix: handle package case change fix: canonicalize paths in the index Sep 29, 2023
"version": 10,
"canonical_name": "alexapy",
"filename": "alexapy-1.27.0-py3-none-any.whl",
"metadata_name": "AlexaPy",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in 1.27.0

@bdraco
Copy link
Owner Author

bdraco commented Sep 29, 2023

https://pypi.org/simple/ seems to use the canon name for the dir, but the first package name it sees as the title of the link which is strange as you would think it would use the canon name for both.

Everything seems to work using the canon name for both which makes more sense to me

@bdraco bdraco marked this pull request as ready for review September 29, 2023 21:06
@bdraco
Copy link
Owner Author

bdraco commented Sep 29, 2023

https://pypi.org/simple/AIOsomecomfort/

redirects to the canon name https://pypi.org/simple/aiosomecomfort/

This seems like it will be fine and is a good fix.

It's so hard to tell though.

We can always revert if needed or change the name to be the newest package meta name

@bdraco bdraco merged commit 331d42a into main Sep 29, 2023
9 checks passed
@bdraco bdraco deleted the alex_name_change branch September 29, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant