-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: canonicalize paths in the index #59
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 97.66% 97.64% -0.03%
==========================================
Files 9 9
Lines 300 297 -3
Branches 39 39
==========================================
- Hits 293 290 -3
Misses 6 6
Partials 1 1
☔ View full report in Codecov by Sentry. |
"version": 10, | ||
"canonical_name": "alexapy", | ||
"filename": "alexapy-1.27.0-py3-none-any.whl", | ||
"metadata_name": "AlexaPy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed in 1.27.0
https://pypi.org/simple/ seems to use the canon name for the dir, but the first package name it sees as the title of the link which is strange as you would think it would use the canon name for both. Everything seems to work using the canon name for both which makes more sense to me |
https://pypi.org/simple/AIOsomecomfort/ redirects to the canon name https://pypi.org/simple/aiosomecomfort/ This seems like it will be fine and is a good fix. It's so hard to tell though. We can always revert if needed or change the name to be the newest package meta name |
Example case
alexpy became AlexPy and we can't see the new wheel so we need to canonicalize the path before figuring out which files to put on the html page