-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Probe Monitoring toggle via gcode. #603
Comments
Please explain the problem behavior and exactly what you want to happen. What does prove on/off do for you? I would rather not guess |
here is a reference from linuxcnc LinuxCNC/linuxcnc#368 The behavior I am looking for is that on the start of a probing macro grbl will turn probe pin monitoring on for non-G38 movements. This will stop the machine if it attempts to move the probe through the work while moving probing start positions. From the above example. I am probing and edge.
The probe may crash on line 1 or line 2 and grbl would just keep going even though the probe was triggered on the pre-G38 positioning move. If probe pin monitoring was active on these intermediate moves grbl could halt and go into alarm when the probe makes contact. So for a macro you'd turn on the monitoring at the beginning, and off at the end of your macro. Something like
|
another option here is to have a probe detect pin which would detect the probe and ensure that the probe pin state is monitored when the probe is "on". This could also be used to lockout turning the spindle on. |
There is some similarity to the safety door code. |
Was that LinuxCNC feature implemented? |
A solution that requires no GCode involvement is to have the probe pin act as a limit switch when not probing. |
https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/motion/control.c#L620 Since recording the position per step ISR tick is expensive in the default mode for probe state monitoring, perhaps it is better to have a new routine that only checks a probe state flag in the same interval used for limit switch checking when not in an G38. I believe the expense of keeping the current stat monitor running is why it is not always on. I would also expect that monitoring probing full time combined with bad wiring and EMI noise will create newbie user issues. |
If the probe were a reset switch most of the time and a probe switch when you needed it to be, that might fix your problem. With the current code, that would rather messy. Reset switches use interrupts and probes do not. If you wired 2 inputs to the switch that would help, but you would need to turn off the reset during probing. Custom macro programming might do it. I don't think it is something the developers would want to implement at this time. We have a lot of other things we want to work on. |
Please describe the feature you would like implemented
GCode command to turn probe pin monitoring on and off
Why do you think this would improve Grbl_ESP32?
When doing multi point probing via a sender/macro the probe may contact the work when moving between probe start positions. The following edge finding example:
Each non-G38 move has the potential to crash the probe.
Another example is heightmap scanning where many moves are made to scan a PCB or other surface.
What do you need the feature for?
the longevity of my probe
Will this feature appear to a lot of users?
anyone who is creating probe macros for multi point probing.
The text was updated successfully, but these errors were encountered: