Add accepted_field_type
for Union
s with Missing
#96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #89 fixed compatibility with Arrow v2.6 except when the schema field's declared type is e.g.
Union{Vector{T},Missing}
and what's passed for validation is someAbstractVector
. This adds a method toaccepted_field_type
that recurses on the non-Missing
type in aUnion
withMissing
. Note that this also necessitated adding an explicitaccepted_field_type
method forAny
to avoid infinite recursion with the fallback definition, since(Union{T,Missing} where {T}) == Any
.