Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puzzle Unlock time is wrong. #238

Closed
beakerandjake opened this issue Dec 1, 2023 · 0 comments · Fixed by #239
Closed

Puzzle Unlock time is wrong. #238

beakerandjake opened this issue Dec 1, 2023 · 0 comments · Fixed by #239
Assignees
@beakerandjake
Labels
bug Something isn't working

Comments

@beakerandjake
Copy link
Owner

Describe the bug

puzzleIsInFuture check is comparing:

const puzzleUnlockTimeUTC = Date.UTC(year, 11, day, 19);

19:00 UTC is 2 PM EST...

The comparison should check:

const puzzleUnlockTimeUTC = Date.UTC(year, 11, day, 5);

To Reproduce
Steps to reproduce the behavior:

  1. Attempt a puzzle some time past 12 am est
  2. CLI returns error: You cannot attempt this puzzle because it is not unlocked yet, check back on December 1 at midnight EST

Expected behavior
The puzzle will be unlocked exactly at midnight EST.
@beakerandjake beakerandjake added the bug Something isn't working label Dec 1, 2023
@beakerandjake beakerandjake self-assigned this Dec 1, 2023
@beakerandjake beakerandjake linked a pull request Dec 1, 2023 that will close this issue
238 puzzle unlock time is wrong #239
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beakerandjake beakerandjake

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

238 puzzle unlock time is wrong beakerandjake/advent-of-code-runner
1 participant
@beakerandjake