Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed request data causing benchmarks to fail; need to gather this data #5

Closed
orubel opened this issue Aug 2, 2019 · 2 comments
Closed

Failed request data causing benchmarks to fail; need to gather this data #5

orubel opened this issue Aug 2, 2019 · 2 comments

Comments

@orubel
Copy link
Collaborator

orubel commented Aug 2, 2019

Need to gather data for failed requests rather than having entire test fail.

Show number of failed requests in comparison. Al;ways forget this as I never have failed requests :)
@orubel
Copy link
Collaborator Author

orubel commented Aug 2, 2019

Also parse for 'non-2xx'; this usually gets triggered by failed requests but can sometimes be thrown on successful returns as well. Weird.

@orubel
Copy link
Collaborator Author

orubel commented Aug 3, 2019

fixed.

@orubel orubel closed this as completed Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orubel