Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Python 2.6 #169

Closed
medecau opened this issue Jul 30, 2016 · 4 comments
Closed

On Python 2.6 #169

medecau opened this issue Jul 30, 2016 · 4 comments
Milestone

Comments

@medecau
Copy link
Contributor

medecau commented Jul 30, 2016

The README says:

Python 2.7 or greater is required for parsedatetime version 1.0 or greater.

I've seen a few recent commits adding support or fixing errors specific to 2.6.

Should we keep supporting 2.6?

@bear
Copy link
Owner

bear commented Jul 30, 2016

I've wanted to keep supporting 2.6 as a few larger projects have that as a requirement.

But yea, we should make sure that the docs are accurate.

@medecau
Copy link
Contributor Author

medecau commented Jul 30, 2016

Keeping the docs up to date would be nice.
More importantly I think is to run tests on python 2.6.
I'm not familiar with with the CI tools currently being used on this repo.
I don't see travis-ci checks. Last build on travis is 5 months old. So I'm not sure where to look.

@bear
Copy link
Owner

bear commented Jul 30, 2016

If you have the spots where the docs are wrong fresh in your brain please do make a PR or I'll take a look later.

The CI tool used is CircleCI, which I switched to because I now work for them :)

I left the .travis.yml in by mistake, i'll remove it after updating circle.yml for 2.6

bear added a commit that referenced this issue Jul 30, 2016
Add import exception for unittest2 when run under Python 2.6 -- fixes Issue #169
@bear
Copy link
Owner

bear commented Jul 30, 2016

k, updating the CircleCI environment to run tests using tox so we are testing under 2.6, 2.7, 3.5 and pypy now

Also updated README with new information about tox and versions being tested

@bear bear closed this as completed Jul 30, 2016
@bear bear mentioned this issue Aug 11, 2016
@idpaterson idpaterson added this to the 2.2 milestone Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants