Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import exception for unittest2 when run under Python 2.6 -- fixes Issue #169 #171

Merged
merged 8 commits into from
Jul 30, 2016

Conversation

bear
Copy link
Owner

@bear bear commented Jul 30, 2016

tweak Makefile to run tox for CI and adjust tests to run unittest2 for Python 2.6


This change is Reviewable

@bear bear changed the title Add import exception for unittest2 when run under Python 2.6 -- fixes Issue 169 Add import exception for unittest2 when run under Python 2.6 -- fixes Issue #169 Jul 30, 2016
@codecov-io
Copy link

codecov-io commented Jul 30, 2016

Current coverage is 76.89% (diff: 100%)

Merging #171 into master will not change coverage

@@             master       #171   diff @@
==========================================
  Files            14         14          
  Lines          1567       1567          
  Methods           0          0          
  Messages          0          0          
  Branches        288        288          
==========================================
  Hits           1205       1205          
  Misses          268        268          
  Partials         94         94          

Powered by Codecov. Last update 0868aab...0f8ce6d

@bear
Copy link
Owner Author

bear commented Jul 30, 2016

this should fix issue #169

@bear
Copy link
Owner Author

bear commented Jul 30, 2016

Reviewed 26 of 26 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bear
Copy link
Owner Author

bear commented Jul 30, 2016

yep, reviewed my own PR :)

@bear bear merged commit 2e78a58 into master Jul 30, 2016
@bear bear deleted the Issue169 branch July 30, 2016 22:53
@idpaterson idpaterson modified the milestone: 2.2 Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants