New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User object to DMs per Issue #344 #384

Merged
merged 3 commits into from Sep 14, 2016

Conversation

Projects
None yet
2 participants
@jeremylow
Collaborator

jeremylow commented Sep 14, 2016

Description

Adds a full-hydrated User object to the DirectMessage object for the sender and recipient properties.

Related Issue

#344

How Has This Been Tested?

Tests added for DirectMessage Model. All prior tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change is Reviewable

jeremylow added some commits Jul 25, 2016

@bear

This comment has been minimized.

Owner

bear commented Sep 14, 2016

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bear bear merged commit 0aabee0 into master Sep 14, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
code-review/reviewable 3 files reviewed
Details
dependency-ci Dependencies checked
Details

@bear bear deleted the fix/issue344 branch Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment