Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent version number tags are incorrect #20

Open
rlaphoenix opened this issue Mar 28, 2023 · 2 comments
Open

Recent version number tags are incorrect #20

rlaphoenix opened this issue Mar 28, 2023 · 2 comments

Comments

@rlaphoenix
Copy link
Collaborator

The git tags for 1.3.0, 1.3.1, and 1.3.2 are wrong. You seemed to have some problems when doing the new release, but we still have the change to fix the tags.

Perhaps remove the tag for 1.3.0 and 1.3.1, but keep the tag for 1.3.2, since technically we are now locked into being 1.3.2 when it should have been 1.3.0 but seemingly issues prevented you from doing that.

@beardypig
Copy link
Owner

I removed the others, but what is wrong with the 1.3.2?

@rlaphoenix
Copy link
Collaborator Author

The fact that it is 1.3.2. Why is it? Following sem-ver rules, that release should have realistically been 1.2.1 or 1.3.0, but definitely not 1.3.2 when no 1.3.1 nor 1.3.0 releases were made yet.

It's already done now though, so it's not really possible to backtrack unless you yank the release on PyPI, re-release as 1.3.0, and withhold the possibility of using 1.3.2 ever again. Even then it's a bit messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants