Distributed tracing: strip query parameters from the operation name #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 73.27% 73.16% -0.12%
==========================================
Files 61 61
Lines 3656 3667 +11
==========================================
+ Hits 2679 2683 +4
- Misses 902 907 +5
- Partials 75 77 +2
Continue to review full report at Codecov.
|
mantzas
previously approved these changes
Jul 27, 2020
# Conflicts: # component/http/middleware.go # component/http/middleware_test.go
|
Closes #239 |
mantzas
approved these changes
Jul 28, 2020
tpaschalis
approved these changes
Jul 28, 2020
Stefos
pushed a commit
to Stefos/patron
that referenced
this pull request
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #239.
Short description of the changes
Strip the query string when creating a new span