Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZR english Strings.po not used in some case #300

Closed
Nanomani opened this issue Jun 14, 2021 · 26 comments · Fixed by #301
Closed

AZR english Strings.po not used in some case #300

Nanomani opened this issue Jun 14, 2021 · 26 comments · Fixed by #301
Labels
Bug Something isn't working Fixed Fixed a bug Kodi 19 Kodi 19 Language Language strings modified or added

Comments

@Nanomani
Copy link
Contributor

see explain here :

https://forum.kodi.tv/showthread.php?tid=337862&pid=3043184#pid3043184

@beatmasterRS
Copy link
Owner

Does this only occur, when the language file doesnt has the located strings? It's strange, that when i add the missing strings to e.g. "Eperanto", so the file conatins the same strings as "English", but the issue still exsists...

@beatmasterRS beatmasterRS added Bug Something isn't working Kodi 19 Kodi 19 labels Jun 14, 2021
@beatmasterRS beatmasterRS linked a pull request Jun 14, 2021 that will close this issue
@beatmasterRS
Copy link
Owner

@Nanomani
Copy link
Contributor Author

It is ok for me. :)
Not tested all changed id strings...
If you are use only empty strings id from Kodi all will be fixed

@beatmasterRS
Copy link
Owner

I have first changed all from 38000 upwards. Used now from 38500

Thanks a lot :)

@beatmasterRS beatmasterRS added the Fixed Fixed a bug label Jun 14, 2021
@beatmasterRS
Copy link
Owner

beatmasterRS commented Jun 19, 2021

Maybe we should use folder named like resource.language.en_gb to get rid of this issue and use all strings? We should test this

@Nanomani

@beatmasterRS beatmasterRS reopened this Jun 19, 2021
@beatmasterRS
Copy link
Owner

@beatmasterRS
Copy link
Owner

I have not tested yet, but maybe the issues got fully fixed..

@Nanomani
Copy link
Contributor Author

more important :

  • strings 31000 thru 31999 reserved for skins
  • translation is empty for "en_GB" labels

@beatmasterRS
Copy link
Owner

beatmasterRS commented Jun 19, 2021

I've made a new branch for that:

https://github.com/beatmasterRS/skin.arctic.zephyr.mod/tree/language-strings-testing

And a PR, so i think its easier to test and discuss...

@beatmasterRS beatmasterRS linked a pull request Jun 19, 2021 that will close this issue
@beatmasterRS
Copy link
Owner

strings.po file with only a few kb, i have deleted for now

@Nanomani
Copy link
Contributor Author

Very good decision 👍

for this "chain 31000 to 31999 reserved for skins", the work is huge ...

msgctxt "#31xxx" => 188 strings
msgctxt "#37xxx" => 483 strings :/
msgctxt "#38xxx" => 19 strings :/

moreover I am sure that there are values that are not or no longer used ...

@beatmasterRS
Copy link
Owner

Omg I thought that the most strings are in the correct range :( I will start to fix this issue today, for a long time :D :l

@beatmasterRS
Copy link
Owner

Do you know an easy way to to this? :l

@Nanomani
Copy link
Contributor Author

Nanomani commented Jun 20, 2021

Perhaps :)
I have already extracted all the "strings ID" that must be replaced :)
I test 2 batch for :

  1. find all "strings ID" not use
  2. replace in all code "strings ID" that must be replaced

give me some time :)

EDIT :
usefull link : https://www.translatum.gr/forum/index.php?topic=463147.0
I make a test with "TextCrawler"

@beatmasterRS
Copy link
Owner

beatmasterRS commented Jun 20, 2021

Have you any news on this? Can you use a finde/replace list in TextCrwaler? I am doing also a few tests now.

@beatmasterRS
Copy link
Owner

If you have the id's, that must be changed, i could generate a list in this format with php:

Image1

@Nanomani
Copy link
Contributor Author

Nanomani commented Jun 20, 2021

First I thinks we must eliminate all ID strings in strings.po en_GB useless ?

"find all "strings ID" not use" => 153 strings :D

msgctxt "#31xxx" => 68 strings
msgctxt "#37xxx" => 85 strings

Search :

D:\GitHub\skin.arctic.zephyr.mod\1080i\ *.xml
D:\GitHub\skin.arctic.zephyr.mod\shortcuts\ *.xml

list ID Strings :

list_ID_strings_full.txt

Result :

results.txt

My batch : (for run del .txt)

(https://github.com/beatmasterRS/skin.arctic.zephyr.mod/files/6682434/search_strings_ID_not.found.cmd.txt)

@beatmasterRS
Copy link
Owner

beatmasterRS commented Jun 20, 2021

Omg, this looks difficult for me :D If i can do anything to help you, please let me know :)

First I thinks we must eliminate all ID strings in strings.po en_GB useless ?

Yes :)

@Nanomani
Copy link
Contributor Author

Nanomani commented Jun 20, 2021

I search a solution for :

search strings then if find delete the line + 2 next line for strings.po :)

EDIT : I have find :p

@beatmasterRS beatmasterRS removed the Fixed Fixed a bug label Jun 20, 2021
@Nanomani
Copy link
Contributor Author

Nanomani commented Jun 20, 2021

153 "strings ID" cleaning for strings.po DE, EN, FR

I have post a PR for testing

PR : #316
ZIP : https://github.com/Nanomani/skin.arctic.zephyr.mod/archive/refs/heads/language-strings-testing-search-replace.zip

can you try and tell me if i can continue with other strings.po or if there is a problem

EDIT :
if okay for you then I do :

  1. a list of all strings 31000 thru 31999 free
  2. a list of all strings "#37xxx" with a new "#31xxx" for replace
  3. search and replace in all file .xml under :
    => D:\GitHub\skin.arctic.zephyr.mod\1080i\ *.xml
    => D:\GitHub\skin.arctic.zephyr.mod\shortcuts\ *.xml

@beatmasterRS
Copy link
Owner

beatmasterRS commented Jun 20, 2021

Absolulety good job, thanks a lot!

Yes, it works absolutely fine for me :) Please continue :) If you like, please add all follwing commits to the PR you have opened :)

@beatmasterRS beatmasterRS added the Language Language strings modified or added label Jun 20, 2021
@beatmasterRS
Copy link
Owner

Thank you so much! :)

@beatmasterRS beatmasterRS added the Fixed Fixed a bug label Jun 21, 2021
@Nanomani
Copy link
Contributor Author

your welcome :)
Thank you for your trust and for this remarkable skin :)

@beatmasterRS
Copy link
Owner

Maybe we can get this skin to the official kodi repo :)

@Nanomani
Copy link
Contributor Author

Maybe we can get this skin to the official kodi repo :)

It's funny i was thinking the same thing. Yes this will be cool and deserved

@Nanomani
Copy link
Contributor Author

Nanomani commented Jun 21, 2021

@beatmasterRS Small detail, what do you think for the next update this number 1.2.0 ? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fixed Fixed a bug Kodi 19 Kodi 19 Language Language strings modified or added
Projects
None yet
2 participants